Skip to content

docs: add ios docs on CPU/battery#217

Merged
rebello95 merged 3 commits intomasterfrom
docs-add-ios-docs-on-cpubattery
Jul 2, 2019
Merged

docs: add ios docs on CPU/battery#217
rebello95 merged 3 commits intomasterfrom
docs-add-ios-docs-on-cpubattery

Conversation

@rebello95
Copy link
Copy Markdown
Contributor

@rebello95 rebello95 commented Jul 2, 2019 •
edited
Loading

  • Adds iOS documentation on the CPU/battery usage based on the investigation done in ios: Battery/CPU usage audit #113
  • Combines the existing documentation for this into a single file for CPU/battery

Resolves #113.

Signed-off-by: Michael Rebello mrebello@lyft.com

@rebello95
docs: add ios docs on CPU/battery
e53596b 
- Adds iOS documentation on the CPU/battery usage based on the investigation done in #113
- Combines the existing documentation for this into a single file for CPU/battery

Resolves #113.

Signed-off-by: Michael Rebello <mrebello@lyft.com>
@rebello95 rebello95 force-pushed the docs-add-ios-docs-on-cpubattery branch from 3d9ef63 to e53596b Compare July 2, 2019 18:43
@rebello95 rebello95 requested a review from buildbreaker July 2, 2019 18:43
buildbreaker
buildbreaker reviewed Jul 2, 2019
View reviewed changes
@rebello95
CR
653c34c 
Signed-off-by: Michael Rebello <mrebello@lyft.com>
junr03
junr03 suggested changes Jul 2, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@junr03 junr03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed write up. A few comments.

docs/root/development/performance/cpu_battery_impact.rst Outdated

Modified versions of the "hello world" example apps were used to run these experiments:

- `Android control app <https://github.com/lyft/envoy-mobile/tree/ac/envoy-battery-cpu-branch/examples/kotlin/control>`_
Copy link
Copy Markdown
Member

@junr03 junr03 Jul 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there is a way to protect these branches from being deleted. I know I sometimes go and prune old branches, so I would like something to yell at me if I try to delete these.

Copy link
Copy Markdown
Contributor Author

@rebello95 rebello95 Jul 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub keeps SHAs around, so I can pin to those instead (that way we could delete the branch and these links would still work)

@rebello95
CR
78c07a9 
Signed-off-by: Michael Rebello <mrebello@lyft.com>
@rebello95
Copy link
Copy Markdown
Contributor Author

rebello95 commented Jul 2, 2019

@junr03 thanks for the feedback. Updated if you'd like to take another look.

@rebello95 rebello95 requested review from buildbreaker and junr03 July 2, 2019 19:55
junr03
junr03 approved these changes Jul 2, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@junr03 junr03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks!

@rebello95 rebello95 merged commit a474af5 into master Jul 2, 2019
@rebello95 rebello95 deleted the docs-add-ios-docs-on-cpubattery branch July 2, 2019 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@buildbreaker buildbreaker Awaiting requested review from buildbreaker

1 more reviewer

@junr03 junr03 junr03 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ios: Battery/CPU usage audit

3 participants

@rebello95 @junr03 @buildbreaker