CI: Move asan workflow to Engflow's remote execution#1745
Merged
goaway merged 46 commits intoenvoyproxy:mainfrom Sep 2, 2021
Merged
CI: Move asan workflow to Engflow's remote execution#1745goaway merged 46 commits intoenvoyproxy:mainfrom
goaway merged 46 commits intoenvoyproxy:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
CI: Move asan workflow to Engflow's remote execution and cut build times by 5x
Before (~2hr):
After (~20min):
Due to google/sanitizers#916 we add an extra capability (SYS_PTRACE) to the remote execution docker container, we do this by adding a new Clang ASAN toolchain. Otherwise, dangling threads can fail the test during teardown (example with a previous run: https://github.com/envoyproxy/envoy-mobile/runs/3443649963).
Risk Level: Low
Testing: See asan workflow
Docs Changes: N/A
Release Notes: N/A