build: fix libtool label for bazel 3.7+#1234
Merged
goaway merged 1 commit intoenvoyproxy:mainfrom Feb 6, 2021
Merged
Conversation
This tool was meant to be a bazel implementation detail so its public accessor was removed in bazelbuild/bazel@f8b51ff Using the cc API from bazel we can dynamically get this. This is still a bit of a hack because we're writing our own args for this. We might be able to fetch the args, based on bazel's crosstool, dynamically as well, but ideally we remove this rule instead. Fixes envoyproxy#1233 Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Closed
rebello95
approved these changes
Jan 12, 2021
Member
Author
|
we should verify it fixes that issue with 3.7 before merging (although I think it'll be compatible before too) |
Contributor
|
Confirmed Android and iOS distros both build on bazel 3.7.2 with this change. |
goaway
approved these changes
Feb 6, 2021
Contributor
|
Thank you @keith! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tool was meant to be a bazel implementation detail so its public
accessor was removed in bazelbuild/bazel@f8b51ff
Using the cc API from bazel we can dynamically get this. This is still a
bit of a hack because we're writing our own args for this. We might be
able to fetch the args, based on bazel's crosstool, dynamically as well,
but ideally we remove this rule instead.
Fixes #1233
Signed-off-by: Keith Smiley keithbsmiley@gmail.com