Skip to content

apple resolver not included in apple builds #2377

@alyssawilk

Description

@alyssawilk

after I fixed #2376 (local patch, tested by sam, real fix coming soon) his next problem was

[external/envoy/source/server/server.cc:117] error initializing configuration '': Unable to parse JSON as proto (INVALID_ARGUMENT:(typed_dns_resolver_config.typed_config): invalid value Invalid type URL, unknown type: extensions.network.dns_resolver.apple.v3.AppleDnsResolverConfig for type Any):

Looking at envoy_build_config/extensions_build_config.bzl I see
"envoy.network.dns_resolver.apple": "//source/extensions/network/dns_resolver/apple:config",
in there and looking at platform selects it should work but did not.

Explicitly linking the resolver in the builder config did work (see below) so I'm not quite sure if Sam's not linking the expected target, or if something is screwy with our build files. Anyone else have an apple machine that can help?

+#include "source/extensions/network/dns_resolver/apple/apple_dns_impl.h"

+++ b/library/cc/BUILD
@@ -14,7 +14,8 @@ envoy_cc_library(
     ],
     repository = "
@Envoy
",
     deps = [
-        ":envoy_engine_cc_lib_no_stamp",
+      "
@Envoy
//source/extensions/network/dns_resolver/apple:config",
+      ":envoy_engine_cc_lib_no_stamp",
     ],
 )

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions