Skip to content

Flaky saveFinalStreamIntel on cancel #2192

@carloseltuerto

Description

@carloseltuerto

cc: @alyssawilk @StefanoDuo

When running on a Linux workstation, about 10% of "cancel" operation end up with blanked saveFinalStreamIntel. The direct reason is that this line of code makes the method to return too early:

https://github.com/envoyproxy/envoy-mobile/blob/main/library/common/http/client.cc#L311

At first sight, the root cause seems to be that the Stream is reclaimed before saveFinalStreamIntel gets captured. When a User invokes "cancel", the sequence is the following in client.cc#518:

    removeStream(direct_stream->stream_handle_);
    direct_stream->callbacks_->onCancel();

The direct_stream->callbacks_->onCancel() invocation is where there is an attempts to capture the latest saveFinalStreamIntel. It fails to do so.

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions