log: fix type name for DelegatingLogSinkSharedPtr#9710
Merged
junr03 merged 3 commits intoenvoyproxy:masterfrom Jan 17, 2020
junr03:fix-type-name
Merged
log: fix type name for DelegatingLogSinkSharedPtr#9710junr03 merged 3 commits intoenvoyproxy:masterfrom junr03:fix-type-name
junr03 merged 3 commits intoenvoyproxy:masterfrom
junr03:fix-type-name
Conversation
Signed-off-by: Jose Nino <jnino@lyft.com>
jmarantz
previously approved these changes
Jan 16, 2020
Member
Author
|
@jmarantz sorry for the triple commit. I was running a bunch of bazel processes locally so I decided to push with I am really wishing for a google workstation right now. |
jmarantz
approved these changes
Jan 17, 2020
Contributor
jmarantz
left a comment
There was a problem hiding this comment.
No worries but I would love to learn more about these awesome workstations you think we have :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: I noticed while reading this file that the shared pointer alias was not following convention. This PR fixes that.
Risk Level: low
Testing: CI
Signed-off-by: Jose Nino jnino@lyft.com