Skip to content

build: remove protobuf_link_hacks.#9191

Closed
htuch wants to merge 1 commit intoenvoyproxy:masterfrom
htuch:link-hacks
Closed

build: remove protobuf_link_hacks.#9191
htuch wants to merge 1 commit intoenvoyproxy:masterfrom
htuch:link-hacks

Conversation

@htuch
Copy link
Copy Markdown
Member

@htuch htuch commented Dec 2, 2019

It's unclear if these are still needed given a number of protobuf library bumps, changes to the API
build system and protocolbuffers/protobuf#4221. Removing the target
doesn't cause any tests to fail.

Risk level: Low
Testing: bazel test //test/... This PR merging is conditional on the Envoy Mobile team confirming
that there is no breakage.

Signed-off-by: Harvey Tuch htuch@google.com

@htuch
build: remove protobuf_link_hacks.
261bb2d 
It's unclear if these are still needed given a number of protobuf library bumps, changes to the API
build system and protocolbuffers/protobuf#4221. Removing the target
doesn't cause any tests to fail.

Risk level: Low
Testing: bazel test //test/... This PR merging is conditional on the Envoy Mobile team confirming
  that there is no breakage.

Signed-off-by: Harvey Tuch <htuch@google.com>
@htuch htuch requested a review from snowp as a code owner December 2, 2019 23:03
@htuch htuch requested review from goaway, junr03 and kyessenov December 2, 2019 23:03
@htuch
Copy link
Copy Markdown
Member Author

htuch commented Dec 2, 2019

@junr03 and @goaway kindly offered to test this out in Envoy Mobile land, so will wait to hear back.

lizan
lizan approved these changes Dec 3, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@lizan lizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, waiting for Envoy Mobile feedback

@junr03
Copy link
Copy Markdown
Member

junr03 commented Dec 3, 2019

I am building and running, will report back when done.

@junr03
Copy link
Copy Markdown
Member

junr03 commented Dec 3, 2019 •
edited
Loading

update: Android ran fine. iOS crashes with the following assertion failure:

2019-12-03 13:06:05.294 app[10203:2561110] Starting Envoy...
2019-12-03 13:06:05.331 app[10203:2561110] Started Envoy, beginning requests...
2019-12-03 13:06:05.350 app[10203:2561110] Finished launching!
[2019-12-03 13:06:05.410][2561517][critical][assert] [external/envoy/source/server/proto_descriptors.cc:44] assert failure: Protobuf::DescriptorPool::generated_pool()->FindMethodByName(method) != nullptr. Details: Unable to find method descriptor for envoy.service.discovery.v2.AggregatedDiscoveryService.StreamAggregatedResources

From mucking around a bit it looks like ADS and ratelimit are missing.

@htuch
Copy link
Copy Markdown
Member Author

htuch commented Dec 3, 2019

@junr03 looking at https://github.com/envoyproxy/protoc-gen-validate/blob/master/bazel/pgv_proto_library.bzl#L74, which is where the C++ proto library is declared for our API deps, it seems we are setting alwaylinks as expected.

@htuch
Copy link
Copy Markdown
Member Author

htuch commented Dec 3, 2019

@junr03 if I look at cat bazel-out/k8-fastbuild/bin/source/exe/envoy-static-2.params (as per the link command line), I get:

...
-Wl,-whole-archive
bazel-out/k8-fastbuild/bin/external/envoy_api/envoy/service/discovery/v2/_objs/pkg_cc_proto/ads.pb.pic.o
-Wl,-no-whole-archive
...

Do you see something similar when you search for ads.pb on iOS builds?

@stale
Copy link
Copy Markdown

stale bot commented Dec 10, 2019

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Dec 10, 2019
@junr03
Copy link
Copy Markdown
Member

junr03 commented Dec 10, 2019

not stale. Waiting on @goaway in offline conversation with @htuch

@stale stale bot removed the stale stalebot believes this issue/PR has not been touched recently label Dec 10, 2019
@stale
Copy link
Copy Markdown

stale bot commented Dec 18, 2019

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Dec 18, 2019
@junr03 junr03 mentioned this pull request Dec 20, 2019
Closed
@stale
Copy link
Copy Markdown

stale bot commented Dec 25, 2019

This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot closed this Dec 25, 2019
@junr03
Copy link
Copy Markdown
Member

junr03 commented Jan 8, 2020

I was working on a stale branch that did not include @htuch merge from last night (https://github.com/envoyproxy/envoy/pull/9526/files#diff-2c3e3c94185709f57afc11c488277313R3). I spent some time fixing before realizing that @htuch had already merged. It would be ideal if we no longer needed this.

@goaway do you mind taking a look at this and seeing if we can get to a place where we don't need the link hack?

@junr03 junr03 reopened this Jan 8, 2020
@stale stale bot removed the stale stalebot believes this issue/PR has not been touched recently label Jan 8, 2020
This was referenced Jan 9, 2020
Merged
Open
@stale
Copy link
Copy Markdown

stale bot commented Jan 15, 2020

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Jan 15, 2020
@stale
Copy link
Copy Markdown

stale bot commented Jan 22, 2020

This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot closed this Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snowp snowp Awaiting requested review from snowp

@goaway goaway Awaiting requested review from goaway

@junr03 junr03 Awaiting requested review from junr03

@kyessenov kyessenov Awaiting requested review from kyessenov

1 more reviewer

@lizan lizan lizan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@junr03 junr03

Labels

stale stalebot believes this issue/PR has not been touched recently waiting

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@htuch @junr03 @lizan @mattklein123