config: warn on registry when deprecated config names were used#9048
Merged
htuch merged 9 commits intoenvoyproxy:masterfrom Nov 26, 2019
Merged
config: warn on registry when deprecated config names were used#9048htuch merged 9 commits intoenvoyproxy:masterfrom
htuch merged 9 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Shikugawa <rei@tetrate.io>
Signed-off-by: Shikugawa <rei@tetrate.io>
lizan
reviewed
Nov 17, 2019
Signed-off-by: Shikugawa <rei@tetrate.io>
htuch
reviewed
Nov 21, 2019
Member
htuch
left a comment
There was a problem hiding this comment.
Thanks, this is really nice. Can you add tests and make sure CI passes?
/wait
Signed-off-by: Shikugawa <rei@tetrate.io>
Signed-off-by: Shikugawa <rei@tetrate.io>
Signed-off-by: Shikugawa <rei@tetrate.io>
lizan
approved these changes
Nov 26, 2019
| auto it = deprecatedFactoryNames().find(name); | ||
| const bool status = it != deprecatedFactoryNames().end(); | ||
| if (status) { | ||
| ENVOY_LOG(warn, "{} is deprecated, use {} instead.", it->first, it->second); |
Member
There was a problem hiding this comment.
@Shikugawa @lizan @htuch shouldn't we also increment the deprecated stat somehow? I feel like we really have to do this as part of our policy and should. @alyssawilk WDYT?
Member
There was a problem hiding this comment.
Reopened #8540, we should increment deprecated stat / disable that in ENVOY_DISABLE_DEPRECATED_FEATURES cases etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: to resolve #8540, warn to envoy users they used deprecated config names
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]