config: regression test for wrong xDS gRPC method descriptor#8945
Merged
mattklein123 merged 6 commits intoenvoyproxy:masterfrom Nov 11, 2019
Merged
config: regression test for wrong xDS gRPC method descriptor#8945mattklein123 merged 6 commits intoenvoyproxy:masterfrom
mattklein123 merged 6 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
Member
|
Awesome thanks for adding this test. So this can go in before redoing the other PR I guess? @wgallagher PTAL |
Contributor
Author
|
No probs. Correct, this is a cleanup/sort-of-safety-measure added to the pre-existing swath of code where the bug was introduced, together with a test that would have caught the error even without this PR's code change. It fits well both before and after the big change. |
wgallagher
reviewed
Nov 8, 2019
wgallagher
reviewed
Nov 8, 2019
|
one comment otherwise +1 |
Signed-off-by: Fred Douglas <fredlas@google.com>
…strings Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
Contributor
Author
|
@mattklein123 ready to go; please merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The restMethod, sotwGrpcMethod, deltaGrpcMethod family turned out to be a bit error-prone. If you accidentally use e.g. deltaGrpcMethod rather than sotw, and pass the result into a newly constructed GrpcMux, nothing will immediately break: the GrpcMux will still be using the sotw request+response protos you intended. However, the gRPC client will identify itself to the server with the wrong method string, causing the server to reject the client.
Added a check to the CDS integration tests that would catch this mistake.
Risk Level: none, just added a test
Testing: added to cds_integration_test
Fixes #8927