upstream: remove thread local cluster after callbacks#7994
upstream: remove thread local cluster after callbacks#7994ramaraochavali wants to merge 2 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
|
@msukalski This seems to fix the issue. Can you PTAL? @mattklein123 Does this change make sense? |
|
/retest |
|
🔨 rebuilding |
|
Thanks @ramaraochavali this does seem correct to me. It would make me feel better though if there was some integration test that covered this, but that might be pretty hard. @snowp any thoughts on this one? |
|
Yeah makes sense to me. Maybe it would be possible to add a regression test for the Redis cluster case if setting up a dedicated test for this is too hard? |
|
@mattklein123 @snowp I tried to see if it is possible to add a test, it seems pretty hard to set that up. Can we merge this and I will continue to see if it is possible to add and do it as a follow-up if I can add? |
|
/retest |
|
🔨 rebuilding |
|
/retest |
|
🔨 rebuilding |
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
|
New commits are not reflecting here. Will close this and open another PR |
Description: Remove thread local cluster after clusterRemoval callback is fired. Fixes #7990.
Risk Level: Low
Testing: Updated
Docs Changes: N/A
Release Notes: N/A
Fixes #7990