upgrade yapf to the latest version#7926
Merged
lizan merged 1 commit intoenvoyproxy:masterfrom Aug 15, 2019
Merged
Conversation
Member
|
@securityinsanity can we exclude generated python files from formatting? |
Member
Author
|
Sure can, I assume those are the ones under: |
Member
|
right, those _pb2.py and _pb2_grpc.py |
fixes envoyproxy#7389 this commit upgrades yapf to the latest version, in an attempt to keep dependencies up to date Signed-off-by: Cynthia Coan <ccoan@instructure.com>
lizan
approved these changes
Aug 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Upgrade yapf to the latest version. We'd like to reuse it in our local repo, and some of the newer versions contain fixes we need.
This required reformatting all the files for their new rules. Happy to change any rules, as necessary.
Risk Level: Low
Testing: Ensure py format checks can still pass.
Docs Changes: N/A
Release Notes: N/A
fixes #7389