Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Member
mattklein123
left a comment
There was a problem hiding this comment.
You are my hero! One question.
/wait-any
| attachmentTimeout_timer_ = new NiceMock<Envoy::Event::MockTimer>(&filter_callbacks_.dispatcher_); | ||
| EXPECT_CALL(*attachmentTimeout_timer_, enableTimer(config_->attachmentTimeout())) | ||
| .WillOnce(Invoke([&](const std::chrono::milliseconds&) { | ||
| attachmentTimeout_timer_->enabled_ = true; |
Member
There was a problem hiding this comment.
Can this actually happen? I don't think so?
Contributor
Author
There was a problem hiding this comment.
I don't think the timer can be invoked literally under enabletimer. My guess is that's the only hook the test author had for squash finishing under async client -> send, but I was mainly trying to preserve existing tests as much as possible.
Member
There was a problem hiding this comment.
Do you mind just adding a TODO to fix this test to make it more realistic? Thank you.
/wait
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup inspired by #7782 where I had to do a bunch of test cleanup because the tests were calling the callback directly rather than using invokeCallback()
This does lose us a synthetic validation in test/common/network/connection_impl_test.cc which the test admitted could not actually happen and from code inspection has been refactored to no longer look dangerous.
Risk Level: n/a (test only)
Testing: tests pass
Docs Changes: n/a
Release Notes: n/a