Skip to content

Introduce --features=compiler_param_file option for windows#7897

Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
greenhouse-org:fix-windows-compile-test
Aug 12, 2019
Merged

Introduce --features=compiler_param_file option for windows#7897
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
greenhouse-org:fix-windows-compile-test

Conversation

@achasveachas
Copy link
Copy Markdown
Contributor

This resolves compile line length issues by triggering a command args file.

This will allow us to use bazel as is without resorting to hacks.

Signed-off-by: @wrowe

Description:
This resolves compile line length issues by triggering a command args file
bazelbuild/bazel#5163

Risk Level: Low

Testing: Tested locally on Windows

Docs Changes: N/A

Release Notes:

Fixes: bazelbuild/bazel#5163

This resolves compile line length issues by triggering a command args file
bazelbuild/bazel#5163

Signed-off-by: William Rowe <wrowe@pivotal.io>
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit dd5eb0c into envoyproxy:master Aug 12, 2019
@wrowe wrowe deleted the fix-windows-compile-test branch December 24, 2019 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compile Line Length Limit hit under Windows

2 participants