build: miscellaneous hygiene fixes#7888
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Aug 12, 2019
Merged
Conversation
Signed-off-by: Alex Konradi <akonradi@google.com>
Rename arguments so that the names used in method declarations and method definitions match. Signed-off-by: Alex Konradi <akonradi@google.com>
Member
|
LGTM, please fix format. |
Signed-off-by: Alex Konradi <akonradi@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Add missing #include and rectify mismatched argument names
Risk Level: Low
Testing: Built affected targets
Docs Changes: N/A
Release Notes: N/A