Skip to content

buffer filter: Deflake RouterRequestPopulateContentLength#7885

Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
euroelessar:buffer-filter-flake
Aug 9, 2019
Merged

buffer filter: Deflake RouterRequestPopulateContentLength#7885
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
euroelessar:buffer-filter-flake

Conversation

@euroelessar
Copy link
Copy Markdown
Contributor

@euroelessar euroelessar commented Aug 9, 2019

Description: Send response back from the fake upstream. Without that the test hits race conditions on shutdown and times out waiting for the response.
Risk Level: n/a
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Fixes #7872

Signed-off-by: Ruslan Nigmatullin <elessar@dropbox.com>
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@mattklein123 mattklein123 self-assigned this Aug 9, 2019
@mattklein123 mattklein123 merged commit 26a1346 into envoyproxy:master Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

buffer_filter_integration_test flake

2 participants