Skip to content

quiche: remove dummy.h, dummy.cc, dummy_test.cc#7871

Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
bencebeky:dummy
Aug 9, 2019
Merged

quiche: remove dummy.h, dummy.cc, dummy_test.cc#7871
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
bencebeky:dummy

Conversation

@bencebeky
Copy link
Copy Markdown
Contributor

Signed-off-by: Bence Béky bnc@google.com

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Description: remove three files that are not part of any build target.
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
[Optional Fixes #Issue]
[Optional Deprecated:]

Signed-off-by: Bence Béky <bnc@google.com>
@mattklein123
Copy link
Copy Markdown
Member

Are there build files that need updating?

/wait-any

@bencebeky
Copy link
Copy Markdown
Contributor Author

Are there build files that need updating?

/wait-any

I do not believe so. No files in the Envoy repository other than the removed ones contain any of the strings "dummy.h", "dummy.cc", or "dummy_test.cc".

Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit 05e3f6e into envoyproxy:master Aug 9, 2019
@bencebeky bencebeky deleted the dummy branch August 9, 2019 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants