test: do not use SpdyString wrapper for std::string#7854
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Aug 7, 2019
bencebeky:spdystring
Merged
test: do not use SpdyString wrapper for std::string#7854mattklein123 merged 1 commit intoenvoyproxy:masterfrom bencebeky:spdystring
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
bencebeky:spdystring
Conversation
Signed-off-by: Bence Béky <bnc@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bence Béky bnc@google.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: This is part of the effort to deprecate SpdyString and HttpString in QUICHE. QuicString has already been removed. These are/were all transparent wrappers to std::string, existing for historical reasons.
Risk Level: low
Testing: this is a change to tests
Docs Changes: n/a
Release Notes: n/a
[Optional Fixes #Issue]
[Optional Deprecated:]