ip tagging: fix old perf TODO in config constructor#7834
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Aug 7, 2019
Merged
ip tagging: fix old perf TODO in config constructor#7834mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Derek Argueta <dereka@pinterest.com>
jmarantz
approved these changes
Aug 6, 2019
Contributor
|
@lizan for senior maintainer approval. |
mattklein123
approved these changes
Aug 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Clears a TODO left by @ccaraman to reduce copies in
IpTaggingFilterConfigconstructor to construct the LC-trie. The optimization opportunities I found werestd::vectors since size is known beforehandstd::moveintoemplace_backforNetwork::Address::CidrRangeto avoid copy constructor (can't use in-place construction since we checkisValid()after construction)std::pair<std::string, std::vector<Network::Address::CidrRange>>intoemplace_backby perfect forwarding the constructor argumentsThis isn't an online path (only called for config construction) so I think this suffices for optimizations here.
Risk Level: low
Testing: existing
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Derek Argueta dereka@pinterest.com