stats: More StatName conversions#7810
Merged
jmarantz merged 13 commits intoenvoyproxy:masterfrom Aug 8, 2019
Merged
Conversation
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
Author
|
/retest |
|
🔨 rebuilding |
Contributor
Author
|
@lizan I had previously thought this PR was all green; but now it's in this "waiting for status..." state. How do I trigger a re-test for this flavor of CI? |
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
snowp
suggested changes
Aug 6, 2019
Contributor
snowp
left a comment
There was a problem hiding this comment.
Makes sense to me, just some style comments
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
mattklein123
reviewed
Aug 6, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
At a high level this LGTM, will defer to @snowp for review.
rgs1
reviewed
Aug 6, 2019
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
Author
Contributor
Author
|
Thanks @snowp -- @envoyproxy/senior-maintainers can I get another round of approval? |
mattklein123
approved these changes
Aug 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Avoid using scope.counter(string) in Zookeeper and ExtAuthz, factoring out some infrastructure for looking up dynamically constructed stat-names for shared use. 6 more files to go and then #4980 can hopefuly be merged, addressing #4196.
Risk Level: low
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a