stats: fix clang-tidy errors in null stats#7760
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Jul 30, 2019
Merged
stats: fix clang-tidy errors in null stats#7760mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
Author
|
/azp run macos |
|
No pipelines are associated with this pull request. |
Contributor
Author
|
/azp run envoy-macos |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
|
mattklein123
approved these changes
Jul 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: for some reason I was able to check in this code that called a virtual function during destruction, which clang-tidy doesn't like. Fortunately it's easy to fix.
Risk Level: low
Testing: //test/common/stats/...
Docs Changes: n/a
Release Notes: n/a