ci: use bazelisk in macCI and build_image#7739
Merged
jmarantz merged 2 commits intoenvoyproxy:masterfrom Jul 30, 2019
Merged
Conversation
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
keith
previously approved these changes
Jul 27, 2019
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
keith
approved these changes
Jul 29, 2019
mattklein123
approved these changes
Jul 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lizan Zhou lizan@tetrate.io
Description:
Using consistent version of Bazel is more important with RBE/Docker sandbox. We only generate toolchain config for specific version of Bazel(now 0.28.0), using Bazelisk as a Bazel wrapper to use specific version from
.bazelversionfile. Bazelisk is already widely used in bazel CI.Risk Level: Low (now in macOS CI only)
Testing: Local
Docs Changes: In follow up to use the image from this PR
Release Notes: N/A