tests: fix an assert failure in codec_impl_fuzz_test#7734
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Jul 26, 2019
Merged
tests: fix an assert failure in codec_impl_fuzz_test#7734mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
Encoding the headers may lead to stream reset, which leads to an assert when callbacks are added. Add the callbacks before encoding to prevent this. Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com>
Member
Author
|
Forgot to mention that this PR fixes oss-fuzz issue 13814. |
Contributor
|
Thanks for catching this! LGTM. |
asraa
approved these changes
Jul 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Encoding the headers may lead to stream reset, which will cause an assert when callbacks are added. Put the callbacks before encoding to prevent this.
Risk Level: low
Testing: fuzz
Docs Changes: N/A
Release Notes: N/A
Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=13814