Skip to content

jwt: improve the JWT filter logging#7731

Merged
lizan merged 1 commit intoenvoyproxy:masterfrom
yangminzhu:jwt
Jul 27, 2019
Merged

jwt: improve the JWT filter logging#7731
lizan merged 1 commit intoenvoyproxy:masterfrom
yangminzhu:jwt

Conversation

@yangminzhu
Copy link
Copy Markdown
Contributor

@yangminzhu yangminzhu commented Jul 26, 2019

Description:
Refactor the JWT filter logging for better debugging experience:

  • Add logger ID jwt
  • Log JWT verification result when multiple tokens are used
  • Remove never used function getProtoConfig()

@qiwzhang @lizan

Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Yangmin Zhu ymzhu@google.com

@yangminzhu yangminzhu requested a review from lizan as a code owner July 26, 2019 04:43
@yangminzhu yangminzhu changed the title jwt: refactor the JWT filter logging jwt: improve the JWT filter logging Jul 26, 2019
qiwzhang
qiwzhang previously approved these changes Jul 26, 2019
lizan
lizan previously approved these changes Jul 26, 2019
Copy link
Copy Markdown
Member

@lizan lizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge master to pick CI update?

Signed-off-by: Yangmin Zhu <ymzhu@google.com>
@yangminzhu
Copy link
Copy Markdown
Contributor Author

@lizan Done. thanks!

@lizan lizan merged commit 2145077 into envoyproxy:master Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants