http: fixing a bug in commonContinue#7720
Merged
alyssawilk merged 3 commits intoenvoyproxy:masterfrom Jul 29, 2019
Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Contributor
Author
|
Alternate to #7708 |
Member
mattklein123
left a comment
There was a problem hiding this comment.
I like this fix much better. WDYT about proceeding with review of this one vs. the other one?
Contributor
Author
|
fine by me |
mattklein123
previously approved these changes
Jul 25, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
Thanks, this looks great to me. If possible it would be great to get @soya3129 to review before merging.
soya3129
reviewed
Jul 26, 2019
| buffer_was_streaming = status == FilterDataStatus::StopIterationAndWatermark; | ||
| commonHandleBufferData(provided_data); | ||
| } else if (complete() && !trailers() && !bufferedData()) { | ||
| // If this filter is doing StopIterationNoBuffer and this stream is terminated with a zero |
Contributor
There was a problem hiding this comment.
Nit: maybe add ASSERT(end_stream_);?
Contributor
|
LGTM. One thing to notice is that a pending PR by @snowp makes sure when a filter returns Continue, the buffered data will get propagated (they are not propagated now). I think in @snowp's PR, we may need a test to verify when a filter adds an empty data frame to end the stream and returns continue, we won't double fin. We don't double fin now because of #7579. |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
This was referenced Feb 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk Level: High (change to HCM)
Testing: new integration test, with header
Docs Changes: n/a
Release Notes: n/a
Fixes #7595