quiche: pass Dispatcher to EnvoyQuicClock/Alarm instead of TimeSystem#7711
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Jul 26, 2019
Merged
quiche: pass Dispatcher to EnvoyQuicClock/Alarm instead of TimeSystem#7711mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Dan Zhang <danzh@google.com>
Contributor
Author
|
/assign @wu-bin @alyssawilk |
Contributor
Author
|
/retest |
|
🔨 rebuilding |
Contributor
Author
|
/retest |
|
🤷♀️ nothing to rebuild. |
Contributor
Author
|
/azp retest |
|
Command 'retest' is not supported by Azure Pipelines. Supported commands
See additional documentation. |
Contributor
Author
|
/azp run envoy-macos |
|
Commenter does not have sufficient privileges for PR 7711 in repo envoyproxy/envoy |
wu-bin
approved these changes
Jul 25, 2019
| quic::QuicTime EnvoyQuicClock::Now() const { | ||
| return quic::QuicTime::Zero() + quic::QuicTime::Delta::FromMicroseconds( | ||
| microsecondsSinceEpoch(time_system_.monotonicTime())); | ||
| return quic::QuicTime::Zero() + quic::QuicTime::Delta::FromMicroseconds(microsecondsSinceEpoch( |
Contributor
There was a problem hiding this comment.
This function seems to be not clang-formated, can you do that?
Contributor
Author
There was a problem hiding this comment.
It is, otherwise the format ci would have failed.
Contributor
There was a problem hiding this comment.
SGTM, thanks for double check.
Contributor
Author
|
/assign @mattklein123 |
Contributor
Author
|
ping? @mattklein123 |
mattklein123
approved these changes
Jul 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently EnvoyQuicClock takes a TimeSystem reference. But TimeSystem objects is not accessible within the scope of its creation. Instead, Event::Dispatcher is accessible in most of the code and also provide access to underlying TimeSource and a per-event loop timestamp which can be helpful for #7177.
For same reason also change EnvoyQuicAlarm to take a Dispatcher reference.
Risk Level: low, not in production
Testing: existing tests passed.
Part of #7177 #2557