router: minor cleanup#7705
Merged
mattklein123 merged 4 commits intoenvoyproxy:masterfrom Jul 28, 2019
Merged
Conversation
Signed-off-by: Derek Argueta <dereka@pinterest.com>
Signed-off-by: Derek Argueta <dereka@pinterest.com>
Signed-off-by: Derek Argueta <dereka@pinterest.com>
dschaller
approved these changes
Jul 24, 2019
Member
dschaller
left a comment
There was a problem hiding this comment.
CORS changes look good to me
Member
Author
|
huh, the envoy-macos build succeeded but the Github check is stuck on "in progress" https://dev.azure.com/cncf/envoy/_build/results?buildId=6649 |
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 7705 in repo envoyproxy/envoy |
Member
|
Agree with @dschaller, looks good. Thanks! |
Member
|
/azp run |
|
Commenter does not have sufficient privileges for PR 7705 in repo envoyproxy/envoy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
make_uniqueshould be preferred hereexplicitfor single-parameter constructorsCorsPolicyImplconstand created via member initializer listRisk Level: Low
Testing: Existing
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Derek Argueta dereka@pinterest.com