grpc-json transcoder: add integration test#7703
Merged
mattklein123 merged 26 commits intoenvoyproxy:masterfrom Aug 14, 2019
Merged
grpc-json transcoder: add integration test#7703mattklein123 merged 26 commits intoenvoyproxy:masterfrom
mattklein123 merged 26 commits intoenvoyproxy:masterfrom
Conversation
When the Audience is not allowed, it should be unauthorized(403) to that api instead of being unauthenticated(401). Signed-off-by: Xuyang Tao <taoxuy@google.com>
Signed-off-by: Xuyang Tao <taoxuy@google.com>
qiwzhang
reviewed
Jul 24, 2019
test/extensions/filters/http/grpc_json_transcoder/grpc_json_transcoder_integration_test.cc
Show resolved
Hide resolved
qiwzhang
reviewed
Jul 24, 2019
test/extensions/filters/http/grpc_json_transcoder/grpc_json_transcoder_integration_test.cc
Outdated
Show resolved
Hide resolved
qiwzhang
reviewed
Jul 24, 2019
test/extensions/filters/http/grpc_json_transcoder/grpc_json_transcoder_integration_test.cc
Outdated
Show resolved
Hide resolved
qiwzhang
reviewed
Jul 24, 2019
test/extensions/filters/http/grpc_json_transcoder/grpc_json_transcoder_integration_test.cc
Outdated
Show resolved
Hide resolved
qiwzhang
reviewed
Jul 24, 2019
test/extensions/filters/http/grpc_json_transcoder/grpc_json_transcoder_integration_test.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: Xuyang Tao <taoxuy@google.com>
qiwzhang
reviewed
Jul 26, 2019
test/extensions/filters/http/grpc_json_transcoder/grpc_json_transcoder_integration_test.cc
Show resolved
Hide resolved
Signed-off-by: Xuyang Tao <taoxuy@google.com>
qiwzhang
reviewed
Jul 26, 2019
Signed-off-by: Xuyang Tao <taoxuy@google.com>
Contributor
|
debug2.out is NOT removed. It is still there. |
qiwzhang
previously approved these changes
Jul 26, 2019
Signed-off-by: Xuyang Tao <taoxuy@google.com>
Signed-off-by: Xuyang Tao <taoxuy@google.com>
Signed-off-by: Xuyang Tao <taoxuy@google.com>
Signed-off-by: Xuyang Tao <taoxuy@google.com>
Signed-off-by: Xuyang Tao <taoxuy@google.com>
Signed-off-by: Xuyang Tao <taoxuy@google.com>
…odingTest Signed-off-by: Xuyang Tao <taoxuy@google.com>
Signed-off-by: Xuyang Tao <taoxuy@google.com>
Signed-off-by: Xuyang Tao <taoxuy@google.com>
Signed-off-by: Xuyang Tao <taoxuy@google.com>
Signed-off-by: Xuyang Tao <taoxuy@google.com>
…Test Signed-off-by: Xuyang Tao <taoxuy@google.com>
Signed-off-by: Xuyang Tao <taoxuy@google.com>
Signed-off-by: Xuyang Tao <taoxuy@google.com>
Contributor
|
LGTM |
lizan
reviewed
Jul 30, 2019
test/extensions/filters/http/grpc_json_transcoder/grpc_json_transcoder_integration_test.cc
Show resolved
Hide resolved
lizan
reviewed
Jul 31, 2019
test/extensions/filters/http/grpc_json_transcoder/grpc_json_transcoder_integration_test.cc
Show resolved
Hide resolved
test/extensions/filters/http/grpc_json_transcoder/grpc_json_transcoder_integration_test.cc
Show resolved
Hide resolved
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Signed-off-by: Xuyang Tao <taoxuy@google.com>
Contributor
Author
|
PTAL, @lizan . I replaced one jsonStr-generate functio(largeJson)n using message but for the invalided jsonStr(deepJson), I guess it may not work in this way. |
lizan
approved these changes
Aug 12, 2019
Member
lizan
left a comment
There was a problem hiding this comment.
LGTM, holding merge til security release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xuyang Tao taoxuy@google.com
Description:
Add the integration tests for
Risk Level:
Low.
Testing:
All are tests.
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]