Update Datadog tracer version to v1.0.1#7701
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Jul 26, 2019
Merged
Conversation
Signed-off-by: Caleb Gilmour <caleb.gilmour@datadoghq.com>
Member
|
/azp run envoy-macos |
Contributor
Author
|
I'll check into the CI errors. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
@cgilmour yeap. To be clear, macOS failure seems like to be real. |
Contributor
Author
|
@dio correct, they're both real and directly related. |
Note: if it passes, a new release of dd-opentracing-cpp will be published. This is not intended for merging yet. Signed-off-by: Caleb Gilmour <caleb.gilmour@datadoghq.com>
10d4545 to
c587e11
Compare
Contributor
Author
|
Note: this is not ready for merging yet. I've made code changes to clear the original CI issues, and verified locally using |
Signed-off-by: Caleb Gilmour <caleb.gilmour@datadoghq.com>
Contributor
Author
|
I've made the updates described in the previous comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Caleb Gilmour caleb.gilmour@datadoghq.com
Description: Updates dd-opentracing-cpp from v0.4.2 to v1.0.0
Fairly minor changes/fixes/features under the hood.
Tiny update to the datadog tracer code in envoy, because it made too much noise with debug enabled.
Risk Level: Low.
Testing: No changes. Passed unit tests and manual E2E tests.
Docs Changes: N/A
Release Notes: N/A