Skip to content

docs: RBE, Docker sandbox and bazel fixes#7657

Merged
jmarantz merged 3 commits intoenvoyproxy:masterfrom
lizan:docs
Aug 1, 2019
Merged

docs: RBE, Docker sandbox and bazel fixes#7657
jmarantz merged 3 commits intoenvoyproxy:masterfrom
lizan:docs

Conversation

@lizan
Copy link
Copy Markdown
Member

@lizan lizan commented Jul 19, 2019

Description:
Added RBE and Docker sandbox how-to.
Make macOS ASAN working again.

Risk Level:
Testing:
Docs Changes: Developer docs
Release Notes:

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan lizan requested a review from jmarantz July 19, 2019 21:13
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
```

Change the value of `--remote_cache`, `--remote_executor` and `--remote_instance_name` for your remote build services. Tests can
be run in remote execution too.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see what this paragraph adds to the above example. The above example seems complete.

Change the value of `--remote_cache`, `--remote_executor` and `--remote_instance_name` for your remote build services. Tests can
be run in remote execution too.

Note: Currently the test run configuration in `.bazelrc` doesn't download test binaries and test logs,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

downloading failed test logs by default seems really useful, particularly if something flakes. If you can't get the log then you may be out of luck.

However, downloading the test binaries seems less useful and more expensive. Is there a way to tease these options apart?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is what I'm asking in bazelbuild/bazel#8934

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. You might want to reference that bug in a comment here?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually that issue is closed now; can you update the default to download test logs?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is not in released bazel yet.

bazel build //source/exe:envoy-static --config=remote-clang \
--remote_cache=grpcs://remotebuildexecution.googleapis.com \
--remote_executor=grpcs://remotebuildexecution.googleapis.com \
--remote_instance_name=projects/envoy-ci/instances/default_instance
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyone can use these googleapis for free?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that's why I the paragraph:

Change the value of --remote_cache, --remote_executor and --remote_instance_name for your remote build services. Tests can be run in remote execution too.

@lizan
Copy link
Copy Markdown
Member Author

lizan commented Jul 26, 2019

@jmarantz gently ping.

Copy link
Copy Markdown
Contributor

@jmarantz jmarantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay, was traveling and this fell off my radar.

Change the value of `--remote_cache`, `--remote_executor` and `--remote_instance_name` for your remote build services. Tests can
be run in remote execution too.

Note: Currently the test run configuration in `.bazelrc` doesn't download test binaries and test logs,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. You might want to reference that bug in a comment here?

@jmarantz jmarantz merged commit 80df094 into envoyproxy:master Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants