test: adding tests for set-cookie being handled correctly#7541
Merged
alyssawilk merged 3 commits intoenvoyproxy:masterfrom Jul 16, 2019
Merged
test: adding tests for set-cookie being handled correctly#7541alyssawilk merged 3 commits intoenvoyproxy:masterfrom
alyssawilk merged 3 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
PiotrSikora
previously approved these changes
Jul 11, 2019
Contributor
PiotrSikora
left a comment
There was a problem hiding this comment.
LGTM, one small nit.
source/common/http/header_utility.h
Outdated
| public: | ||
| enum class HeaderMatchType { Value, Regex, Range, Present, Prefix, Suffix }; | ||
|
|
||
| // Get all instances of the header key specified, and return the values in the |
Contributor
There was a problem hiding this comment.
Nit: Could you turn this into
/*
* Get all instances of the header key specified.
* @param ...
* @param ...
*/
style comment and move it after struct HeaderData?
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yay, we're doing it right!
Risk Level: n/a (test only)
Testing: yes
Docs Changes: no
Release Notes: no
#7488