tests: remove redundant std::move()#7535
Merged
alyssawilk merged 1 commit intoenvoyproxy:masterfrom Jul 11, 2019
Merged
Conversation
Description: gcc9 reports the uses of std::move() redundant. Risk Level: low Testing: unit tests Release Notes: N/A Documentation: N/A Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@linux.intel.com>
lizan
approved these changes
Jul 11, 2019
Contributor
|
Thanks again for the clean up. |
Member
Author
|
@alyssawilk sure. Sorry for the noise. Just that I decided to build the tests today, after I had submitted the first patch. |
Contributor
|
No worries - 2 cleanup CLs is totally reasonable (and thanks again for the clean up!) We had a handful of folks come through earlier this year with something like 5 mini cleanup cls a day so I tend to encourage batching early after that :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: gcc9 reports the uses of std::move() redundant.
Risk Level: low
Testing: unit tests
Release Notes: N/A
Documentation: N/A