filter: add network filters to the upstreams#7503
Merged
mattklein123 merged 34 commits intoenvoyproxy:masterfrom Jul 28, 2019
Merged
filter: add network filters to the upstreams#7503mattklein123 merged 34 commits intoenvoyproxy:masterfrom
mattklein123 merged 34 commits intoenvoyproxy:masterfrom
Conversation
Allow network filters to be installed via cluster configuration, uses the same configuration syntax as listener filters. Added the following: - Cluster filter config: api/envoy/api/v2/cluster/filter.proto - Test to verify filters are applied: test/common/upstream/cluster_manager_impl_test.cc - Create filter factory and apply to new upstream connnections - Implement Server::Configuration::FactoryContext using contexts from TransportSocketFactoryContext NEEDS MINOR WORK: Some FactoryContext functions throw NOT_IMPLEMENTED, because some context objects are not obviously available to the upstream code. Needs attention from someone better versed in the architecture, see TODO(aconway) This does not prevent use of the feature, most contexts are available. This feature is used by project: https://github.com/alanconway/envoy-amqp. Signed-off-by: Alan Conway <aconway@redhat.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
kyessenov
commented
Jul 9, 2019
lambdai
reviewed
Jul 10, 2019
mattklein123
requested changes
Jul 10, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
Thanks for getting this going again. This is definitely the right direction, but a few high level comments to get started:
- We will needs docs, release notes, etc.
- I would like to see an integration test for this with a fake filter.
Thank you!
/wait
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Contributor
Author
|
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
mattklein123
requested changes
Jul 25, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
Thanks this is awesome. Some small comments.
/wait
| for (ssize_t i = 0; i < filters.size(); i++) { | ||
| const auto& proto_config = filters[i]; | ||
| const std::string& string_name = proto_config.name(); | ||
| ENVOY_LOG(debug, " upstream filter #{}:", i); |
Member
There was a problem hiding this comment.
What does this debug output look like? It's printed for every cluster so just want to make sure it's useful.
Contributor
Author
There was a problem hiding this comment.
Here is a sample:
[2019-07-25 22:02:21.833][26][info][config] [source/server/configuration_impl.cc:68] loading 1 cluster(s)
[2019-07-25 22:02:21.833][27][debug][grpc] [source/common/grpc/google_async_client_impl.cc:43] completionThread running
[2019-07-25 22:02:21.839][26][debug][upstream] [source/common/upstream/upstream_impl.cc:695] upstream filter #0:
[2019-07-25 22:02:21.839][26][debug][upstream] [source/common/upstream/upstream_impl.cc:696] name: envoy.upstream.polite
[2019-07-25 22:02:21.839][26][debug][upstream] [source/common/upstream/cluster_manager_impl.cc:838] adding TLS initial cluster cluster_0
[2019-07-25 22:02:21.840][26][debug][upstream] [source/common/upstream/upstream_impl.cc:845] initializing secondary cluster cluster_0 completed
Signed-off-by: Kuat Yessenov <kuat@google.com>
Contributor
Author
|
Thanks for the detailed review! Updated the PR to take the feedback into account. |
Signed-off-by: Kuat Yessenov <kuat@google.com>
mattklein123
requested changes
Jul 26, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
Nice, great work. Just 1 small test request.
/wait
mattklein123
requested changes
Jul 26, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
Looks great with one tiny nit. Thanks!
/wait
| } | ||
|
|
||
| private: | ||
| std::string greeting; |
Member
There was a problem hiding this comment.
nit: const std::string greeting_;
Member
There was a problem hiding this comment.
Sorry you are missing the trailing underscore.
/wait
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Resurrection of PR #6173.
Introduces network filters bound to the upstream clusters.
Risk Level: low
Testing: unit tests
Docs Changes: see #6173
Release Notes: add upstream network filters