tools: update our release scripts#7493
Merged
alyssawilk merged 4 commits intoenvoyproxy:masterfrom Jul 11, 2019
Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
lizan
reviewed
Jul 9, 2019
| # grep source code looking for reloadable features which are true to find the | ||
| # PR they were added. | ||
| grep_output = subprocess.check_output( | ||
| 'grep -r "envoy.reloadable_features\." source/*', shell=True) |
| import github | ||
| from git import Repo | ||
|
|
||
| try: |
Member
There was a problem hiding this comment.
did we move completely to python3 on this?
Contributor
Author
There was a problem hiding this comment.
I thought we'd switched our tools to 3 by default, and I handled a bunch of string-bytestring compat issues I think were Python 3, and it seems to work without this try phrase. I can add it back if that's not enough?
Member
There was a problem hiding this comment.
From https://github.com/envoyproxy/envoy/blob/master/tools/deprecate_version/deprecate_version.sh I don't think it is forced to run under Python 3? Python 2 input is interpreting the input as python script, (i.e. eval(raw_input())), so if not sure let's keep this. Or force Python 3 in the shell script as this one is likely only run by maintainer.
lizan
approved these changes
Jul 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functionally this
In practice, this just hot swaps what our deprecation script does and updates the docs.
Risk Level: n/a (tooling + comment)
Testing: manual testing. Will do one more manual test with actual bug filing just before submitting.
Docs Changes: updated
Release Notes: n/a
Fixes #6472