Add socket option names for debugging.#7457
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Jul 10, 2019
Merged
Conversation
07155b1 to
5d8cb80
Compare
mattklein123
requested changes
Jul 3, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
Thanks, in general this looks like a nice improvement. Can you check CI and also add some tests? Thank you!
/wait
Member
There was a problem hiding this comment.
Mild preference for using a struct here vs. a tuple since IMO it's easier to read.
Contributor
Author
There was a problem hiding this comment.
Yeh I went tuple because it began with pair, but I agree a struct is better.
5d8cb80 to
407a3d4
Compare
407a3d4 to
b906007
Compare
Capture a human-readable name for a socket option so that if setting it fails, the log message can indicate which option was problematic. Signed-off-by: James Peach <jpeach@apache.org>
b906007 to
43a6ef6
Compare
Contributor
Author
|
@mattklein123 I switched from a tuple to a struct, and added an extra test for the option name. PTAL. |
mattklein123
requested changes
Jul 9, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
Thanks this is a nice improvement. 2 small comments. Also, friendly request to please not force push, it makes reviews much harder. Just add commits and we will squash when we merge. Thank you!
/wait
Signed-off-by: James Peach <jpeach@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Capture a human-readable name for a socket option so that if setting
it fails, the log message can indicate which option was problematic.
Risk Level:
Low
Testing:
Verified that trying to set the TCP fast open socket option to 15 on macOS logs which socket option failed.
Docs Changes:
None.
Release Notes:
None.