Skip to content

fuzz: fix filesystem crash#7360

Merged
htuch merged 1 commit intoenvoyproxy:masterfrom
asraa:fsserverfuzz
Jun 24, 2019
Merged

fuzz: fix filesystem crash#7360
htuch merged 1 commit intoenvoyproxy:masterfrom
asraa:fsserverfuzz

Conversation

@asraa
Copy link
Copy Markdown
Contributor

@asraa asraa commented Jun 21, 2019

Possible fix for filesystem crash in server fuzz test due to #7339

Testing: Add corpus entry
Issue
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=15414

Signed-off-by: Asra Ali asraa@google.com

Signed-off-by: Asra Ali <asraa@google.com>
@asraa
Copy link
Copy Markdown
Contributor Author

asraa commented Jun 21, 2019

/review htuch

Verification that this is the fix is unfortunately difficult. Reproducing the fuzz bug in the oss-fuzz docker image comes up as no error, while running the test either locally with bazel and asan, or using envoy's docker build and bazel.asan brings up unrelated asan issues.

@repokitteh-read-only repokitteh-read-only bot requested a review from htuch June 21, 2019 21:12
@asraa asraa marked this pull request as ready for review June 24, 2019 16:45
@asraa
Copy link
Copy Markdown
Contributor Author

asraa commented Jun 24, 2019

Update: Minijail on the production environment for OSS-Fuzz prohibits mkdir from going through, which causes the crash in production, but not in the OSS-Fuzz docker image environments. It turns out that the mkdir branch was being taken after #7339, and this should fix that issue.

Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@htuch htuch merged commit 62cf5d8 into envoyproxy:master Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants