quiche: build quiche libraries#7340
Conversation
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
|
/assign wub |
|
wub cannot be assigned to this issue. |
|
/assign @wu-bin |
Signed-off-by: Dan Zhang <danzh@google.com>
wu-bin
left a comment
There was a problem hiding this comment.
Look good! Just some nits on naming.
|
|
||
| template <typename T> class QuicReferenceCountedPointerImpl { | ||
| public: | ||
| static_assert(std::is_base_of<QuicReferenceCountedImpl, T>::value, |
There was a problem hiding this comment.
Just curious, can I know what is the reason for this change?
There was a problem hiding this comment.
T might be just a forward declaration. In such case, this static_assert is checking incomplete type
bazel/external/quiche.BUILD
Outdated
| name = "quic_platform_ip_address", | ||
| srcs = ["quiche/quic/platform/api/quic_ip_address.cc"], | ||
| hdrs = ["quiche/quic/platform/api/quic_ip_address.h"], | ||
| name = "quic_core_ack_listener_interface", |
There was a problem hiding this comment.
The internal name is "quic_ack_listener_interface_lib", please keep them in sync.
bazel/external/quiche.BUILD
Outdated
| srcs = ["quiche/quic/platform/api/quic_socket_address.cc"], | ||
| hdrs = ["quiche/quic/platform/api/quic_socket_address.h"], | ||
| copts = quiche_copt, | ||
| name = "quic_core_alarm_interface", |
There was a problem hiding this comment.
Same here, the internal name is "quic_alarm_interface_lib"
bazel/external/quiche.BUILD
Outdated
| # "quiche/quic/platform/api/quic_fuzzed_data_provider.h", | ||
| # "quiche/quic/platform/api/quic_test_loopback.h", | ||
| ], | ||
| name = "quic_core_alarm_factory_interface", |
There was a problem hiding this comment.
Should be quic_core_alarm_factory_interface_lib.
Can you go through this file and make sure all core library names are in sync? (looks like names end with "_interface" are different)
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
|
/assign @alyssawilk |
|
/assign @mattklein123 |
Build quiche libraries needed for integration.
Update tar ball to 77ae31cbfb5bf41299c8c10a06a205a8a0d37cae. Remove quic_socket_address_impl.h. Add quic_bbr2_sender_impl.h. Update quic_logging_impl.h to support printing vector.
Sort all quic build targets in quiche.BUILD in alphabetical order.
Risk Level: low, not in use
Testing: no new code added, as long as bazel/external/quiche.BUILD compiles, it's fine.
Part of #2557