bazel: Force python 2 for host tools#7337
Merged
lizan merged 1 commit intoenvoyproxy:masterfrom Jun 20, 2019
Merged
Conversation
bazelbuild/bazel#8626 Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Member
Author
|
I'm not 100% sure this will work for us, but I want to see what CI thinks |
Member
|
Do we know where we are not Python 3 compliant? Can we make sure we have an issue to track fixing that? IIRC I thought we could potentially also somehow just force this on specific broken tests which would make it easier to track. cc @lizan |
Member
|
@mattklein123 #7305 was trying to fix it in particular tests but didn't work. @keith I'm going to merge this to see if bazel ci works. Can you create an issue for tracking? |
lizan
approved these changes
Jun 20, 2019
Member
Author
This was referenced Jun 24, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bazelbuild/bazel#8626
Signed-off-by: Keith Smiley keithbsmiley@gmail.com
Risk Level: Low