fault: destroy rate limiter during reset#7327
Merged
mattklein123 merged 3 commits intomasterfrom Jun 20, 2019
Merged
Conversation
Member
Author
I'm not sure it is related, but I suspect it is. I think the sequence is:
As a follow up I'm going to look at the HCM and potentially put in some release asserts that would catch this, as this type of issue is very hard to debug in general. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably related to #7179
Risk Level: Low
Testing: New UT
Docs Changes: N/A
Release Notes: N/A