csrf filter: add support for additional source origins#7297
Merged
mattklein123 merged 7 commits intoenvoyproxy:masterfrom Jun 18, 2019
Merged
csrf filter: add support for additional source origins#7297mattklein123 merged 7 commits intoenvoyproxy:masterfrom
mattklein123 merged 7 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Derek Schaller <dschaller@lyft.com>
Signed-off-by: Derek Schaller <dschaller@lyft.com>
Member
Author
|
/retest |
|
🔨 rebuilding |
Signed-off-by: Derek Schaller <dschaller@lyft.com>
mattklein123
requested changes
Jun 17, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
Thanks for this, at a high level looks good but one API question to get started.
/wait
Signed-off-by: Derek Schaller <dschaller@lyft.com>
added 2 commits
June 17, 2019 13:03
Signed-off-by: Derek Schaller <dschaller@lyft.com>
Signed-off-by: Derek Schaller <dschaller@lyft.com>
Member
Author
|
/retest |
|
🐴 hold your horses - no failures detected, yet. |
Member
Author
|
@mattklein123 can you rerun that macos azure build for me? |
mattklein123
requested changes
Jun 18, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
Thanks, LGTM. Can you merge master to fix CI?
/wait
Signed-off-by: Derek Schaller <dschaller@lyft.com>
Member
Author
|
Thanks for reviewing @mattklein123 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Schaller dschaller@lyft.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: Add feature to CSRF filter to support whitelisting additional source origins.
Risk Level: Low
Testing: Included unit tests and sandbox changes (manually tested)
Docs Changes: Included
Release Notes: Included