Skip to content

docs: fix requirements for csrf sandbox#7296

Merged
snowp merged 1 commit intoenvoyproxy:masterfrom
dschaller:csrf-sandbox-docs
Jun 17, 2019
Merged

docs: fix requirements for csrf sandbox#7296
snowp merged 1 commit intoenvoyproxy:masterfrom
dschaller:csrf-sandbox-docs

Conversation

@dschaller
Copy link
Copy Markdown
Member

Signed-off-by: Derek Schaller dschaller@lyft.com

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Description: Remove docker-machine dependency from CSRF sandbox docs
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Derek Schaller <dschaller@lyft.com>
@moderation
Copy link
Copy Markdown
Contributor

I missed this in my earlier review. LGTM.

@dschaller
Copy link
Copy Markdown
Member Author

/retest

@repokitteh-read-only
Copy link
Copy Markdown

🔨 rebuilding ci/circleci: coverage (failed build)

🐱

Caused by: a #7296 (comment) was created by @dschaller.

see: more, trace.

Copy link
Copy Markdown
Contributor

@snowp snowp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snowp snowp merged commit c1b98bb into envoyproxy:master Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants