rbac: add rbac to architecture overview#7289
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Jun 20, 2019
Merged
Conversation
lizan
reviewed
Jun 15, 2019
mattklein123
requested changes
Jun 17, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
Thank you this is awesome!
/wait
lizan
previously approved these changes
Jun 17, 2019
Signed-off-by: Yangmin Zhu <ymzhu@google.com>
Signed-off-by: Yangmin Zhu <ymzhu@google.com>
Contributor
Author
|
Thanks for the review, I just rebased and force pushed to trigger a new test (previously the tsan failed) |
Contributor
Author
|
@lizan @mattklein123 PTAL, Also Does the |
Member
|
feel free to ignore macos failure, it is not relevant |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yangmin Zhu ymzhu@google.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: Add rbac to architecture overview
Risk Level: Low
Testing: n/a
Docs Changes: This PR updates the architecture overview
Release Notes: n/a
[Optional Fixes #Issue]
[Optional Deprecated:]
For #7285
cc @lizan @mattklein123