docs: link http filter and network filters in listener proto#7274
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Jun 17, 2019
Merged
docs: link http filter and network filters in listener proto#7274mattklein123 merged 3 commits intoenvoyproxy:masterfrom
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
Contributor
Author
|
@mattklein123 Please see if this makes sense |
Member
mattklein123
left a comment
There was a problem hiding this comment.
Agreed, nice improvement. One small question. Thank you.
/wait-any
| // * :ref:`envoy.ratelimit <config_network_filters_rate_limit>` | ||
| // * :ref:`envoy.redis_proxy <config_network_filters_redis_proxy>` | ||
| // * :ref:`envoy.tcp_proxy <config_network_filters_tcp_proxy>` | ||
| // filter. Refer to :ref:`HTTP filters<config_http_filters>` and |
Member
There was a problem hiding this comment.
I think this is only used for listener/network/UDP filters and not HTTP? Can you check?
Contributor
Author
There was a problem hiding this comment.
Yeah. Good catch. I totally forgot that we configure http filters in Http Connection Manager and listener filters are configured at a different place. Fixed. PTAL.
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rama Chavali rama.rao@salesforce.com
Description: While reviewing a Istio PR I realized we have a hard coded minimal list of filters in the
listener.proto. This PR links it to full list of http and network filters.Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A