ci: add the ability to run only a subset of tests.#7269
Merged
mattklein123 merged 5 commits intoenvoyproxy:masterfrom Jun 20, 2019
Merged
ci: add the ability to run only a subset of tests.#7269mattklein123 merged 5 commits intoenvoyproxy:masterfrom
mattklein123 merged 5 commits intoenvoyproxy:masterfrom
Conversation
While there, cleanup and add missing targets to the README.md file. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Contributor
Author
|
Note: This uses existing syntax that was already available in |
Member
|
LGTM, @htuch for bash sanity check. |
htuch
reviewed
Jun 14, 2019
Member
There was a problem hiding this comment.
LGTM, but one additional thought; for coverage we have https://github.com/envoyproxy/envoy/blob/master/test/run_envoy_bazel_coverage.sh#L23; do you think you could unify this with your new CLI style?
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Contributor
Author
|
@htuch Done, let me know if this works for you. |
Contributor
Author
|
Erm, it cannot find .gcno files, since the old code assumes single target. Let me fix that. /wait |
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
lizan
previously approved these changes
Jun 14, 2019
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Member
|
LGTM, merge master? |
…bset Signed-off-by: Piotr Sikora <piotrsikora@google.com>
lizan
approved these changes
Jun 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While there, cleanup and add missing targets to the README.md file.
Signed-off-by: Piotr Sikora piotrsikora@google.com