rtds: Runtime Discovery Service implementation.#7251
Merged
mattklein123 merged 11 commits intoenvoyproxy:masterfrom Jun 18, 2019
Merged
rtds: Runtime Discovery Service implementation.#7251mattklein123 merged 11 commits intoenvoyproxy:masterfrom
mattklein123 merged 11 commits intoenvoyproxy:masterfrom
Conversation
Fixes envoyproxy#6708. Risk level: Low Testing: Unit and integration tests added. Signed-off-by: Harvey Tuch <htuch@google.com>
mattklein123
requested changes
Jun 13, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
Nice. Pretty awesome to see how relatively easy this was to implement with all the xDS common code we have now. A few small comments.
/wait
Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
mattklein123
requested changes
Jun 14, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
Nice, found one remaining TDS. Thanks a ton for the annoying name fixup.
/wait
Signed-off-by: Harvey Tuch <htuch@google.com>
mattklein123
approved these changes
Jun 18, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
Needs master merge to fix CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6708.
Risk level: Low
Testing: Unit and integration tests added.
Signed-off-by: Harvey Tuch htuch@google.com