test: add process_object_ to BaseIntegrationTest#7183
Merged
alyssawilk merged 2 commits intoenvoyproxy:masterfrom Jun 18, 2019
Merged
test: add process_object_ to BaseIntegrationTest#7183alyssawilk merged 2 commits intoenvoyproxy:masterfrom
alyssawilk merged 2 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Ashley Hedberg <ahedberg@google.com>
Contributor
Author
|
Friendly ping @junr03? |
Member
Signed-off-by: Ashley Hedberg <ahedberg@google.com>
Contributor
Author
|
Test added, PTAL. Thanks! |
Contributor
Author
Contributor
Author
|
Ping @junr03 |
Contributor
Author
|
Thanks for the review! Harvey is out of office until Thursday--Alyssa, mind doing the final pass? /assign @alyssawilk |
alyssawilk
approved these changes
Jun 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ashley Hedberg ahedberg@google.com
Description: Adds a process_object_ member to BaseIntegrationTest. If an integration test subclassing from BaseIntegrationTest sets this member, the envoy server will be started with a ProcessContext referencing that object.
Risk Level: low (test-only, defaults to nullopt)
Testing: bazel test //test/... - not sure if stats_integration_test failures were related. Also not sure where to add a test for this, but happy to do so (I have an internal test that proves this does what I wanted it to).
Docs Changes: none
Release Notes: n/a
Fixes #6969