Skip to content

cleanup: followup cleanup for #7037#7097

Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
eziskind:cleanup
May 29, 2019
Merged

cleanup: followup cleanup for #7037#7097
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
eziskind:cleanup

Conversation

@eziskind
Copy link
Copy Markdown
Contributor

Description: remove commented-out code that I left by mistake from a previous PR
Risk Level: low
Testing: unit tests

Signed-off-by: Elisha Ziskind eziskind@google.com

Signed-off-by: Elisha Ziskind <eziskind@google.com>
mattklein123
mattklein123 previously approved these changes May 29, 2019
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mattklein123 mattklein123 self-assigned this May 29, 2019
Signed-off-by: Elisha Ziskind <eziskind@google.com>
@eziskind eziskind changed the title cleanup: remove commented-out code cleanup: followup cleanup for #7037 May 29, 2019
@eziskind
Copy link
Copy Markdown
Contributor Author

Also fixed format which was broken by the new rule to disallow absl::make_unique

@mattklein123 mattklein123 merged commit 9f1177d into envoyproxy:master May 29, 2019
@eziskind eziskind deleted the cleanup branch May 29, 2019 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants