Skip to content

config: split SubscriptionFactory into .cc and .h#7069

Merged
htuch merged 2 commits intoenvoyproxy:masterfrom
fredlas:TPL_split_sub_factory
May 28, 2019
Merged

config: split SubscriptionFactory into .cc and .h#7069
htuch merged 2 commits intoenvoyproxy:masterfrom
fredlas:TPL_split_sub_factory

Conversation

@fredlas
Copy link
Copy Markdown
Contributor

@fredlas fredlas commented May 24, 2019

Another .h split enabled by xDS detemplatization. (Followup to #6391)

Risk Level: none

fredlas added 2 commits May 24, 2019 11:09
Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, fantastic, thanks!

@htuch htuch merged commit c1ba62c into envoyproxy:master May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants