stats: Capture all StatNames needed in the hystrix filter at construction time.#7046
Merged
mattklein123 merged 5 commits intoenvoyproxy:masterfrom May 28, 2019
Merged
Conversation
…ymbolTables in codes_speed_test. Signed-off-by: Joshua Marantz <jmarantz@google.com>
ahedberg
previously approved these changes
May 23, 2019
ambuc
previously approved these changes
May 23, 2019
Contributor
ambuc
left a comment
There was a problem hiding this comment.
LGTM, almost no comments. This is an encouraging PR demonstrating that we can move off string-based stat names!
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
Author
|
/retest |
|
🔨 rebuilding |
Contributor
Author
|
/retest |
|
🔨 rebuilding |
mattklein123
requested changes
May 27, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
LGTM w/ small nit. Thank you.
/wait
Signed-off-by: Joshua Marantz <jmarantz@google.com>
mattklein123
approved these changes
May 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: To avoid taking locks in the hot-path, captures all the tokens needed to compose stat-names in the Hystrix sink when it's constructed. This avoids taking locks in the hot-path.
Also adds both real-symbol-table and fake-symbol-table variants to codes_speed_test.cc. On my machine this gets:
Risk Level: low
Testing: hystrix_test and the speed test
Docs Changes: n/a
Release Notes: n/a