Skip to content

Add OpenLab CI configuration#6981

Merged
lizan merged 1 commit intoenvoyproxy:masterfrom
theopenlab:envoy_openlab_ci
Jun 19, 2019
Merged

Add OpenLab CI configuration#6981
lizan merged 1 commit intoenvoyproxy:masterfrom
theopenlab:envoy_openlab_ci

Conversation

@Yikun
Copy link
Copy Markdown
Contributor

@Yikun Yikun commented May 17, 2019

This patch adds the OpenLab CI configuration to enable the support for Envoy arm64 build in OpenLab.

After this, each pull request in envoy will trigger the envoy-arm64-build job which verified the arm build on OpenLab ARM cluster.

As the first version, we mark this job as non-voting job, that means the build job result is just a reference for developer and would not block the PR to be merged. Once we make sure the job can be executed stable, then we can mark it as normal "voting" job.

Related: #1861

This was referenced May 17, 2019
Closed
Closed
@stale
Copy link
Copy Markdown

stale bot commented May 24, 2019

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label May 24, 2019
@Yikun
Copy link
Copy Markdown
Contributor Author

Yikun commented May 25, 2019

Any suggestion on this pr? : ) The demonstration results was shown in [1].
[1] #1861 (comment)

@stale stale bot removed the stale stalebot believes this issue/PR has not been touched recently label May 25, 2019
@Yikun Yikun changed the title [WIP] Add OpenLab CI configuration Add OpenLab CI configuration May 25, 2019
@Yikun Yikun force-pushed the envoy_openlab_ci branch from 0c1a3a1 to cfdea5a Compare May 29, 2019 08:30
@dio
Copy link
Copy Markdown
Member

dio commented May 29, 2019

@Yikun Sorry, seems like you need to fix DCO. https://github.com/envoyproxy/envoy/blob/master/CONTRIBUTING.md#fixing-dco

@Yikun Yikun force-pushed the envoy_openlab_ci branch from cfdea5a to 4ac2473 Compare May 29, 2019 08:58
@Yikun
Copy link
Copy Markdown
Contributor Author

Yikun commented May 29, 2019

@dio Thanks for reminder and help, done.

@stale
Copy link
Copy Markdown

stale bot commented Jun 5, 2019

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Jun 5, 2019
@lizan
Copy link
Copy Markdown
Member

lizan commented Jun 6, 2019

@Yikun Can you merge master?

@stale stale bot removed the stale stalebot believes this issue/PR has not been touched recently label Jun 6, 2019
@Yikun
Add OpenLab CI configuration
a2d21d1 
This patch adds the OpenLab CI configuration to enable
the support for Envoy arm64 build in OpenLab.

After this, each pull request in envoy will trigger the
envoy-arm64-build job which verified the arm build
on OpenLab ARM cluster.

Related: envoyproxy#1861
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
@Yikun Yikun force-pushed the envoy_openlab_ci branch from 4ac2473 to a2d21d1 Compare June 6, 2019 08:46
@Yikun
Copy link
Copy Markdown
Contributor Author

Yikun commented Jun 10, 2019

@lizan I have rebase the code to master. : ) Thanks for reminder

@stale
Copy link
Copy Markdown

stale bot commented Jun 17, 2019

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Jun 17, 2019
lizan
lizan approved these changes Jun 19, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@lizan lizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, thanks!

@stale stale bot removed the stale stalebot believes this issue/PR has not been touched recently label Jun 19, 2019
@lizan lizan merged commit 1dc5f64 into envoyproxy:master Jun 19, 2019
@kiwik kiwik deleted the envoy_openlab_ci branch June 19, 2019 07:06
@Yikun Yikun mentioned this pull request Jun 19, 2019
Closed
@lubinsz lubinsz mentioned this pull request Jul 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lizan lizan lizan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lizan lizan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Yikun @dio @lizan