Make close condition more readable#6954
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom May 15, 2019
Merged
Conversation
This is a follow-up to envoyproxy#6942. This makes it a bit more readable. We spent some time debugging this too, so it would be nice to ensure it's readable next time we bump into something around this code surface :-) Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
mattklein123
requested changes
May 15, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
No strong preference but if you think this is easier to read sgtm. Can you make sure all the new branches have explicit coverage? Thank you.
/wait
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Member
Author
|
Yeah I'll ensure we have full coverage too. |
Member
Author
|
/retest |
|
🤷♀️ nothing to rebuild. |
Member
Author
|
Coverage seems to be already OK, per https://217235-65214191-gh.circle-artifacts.com/0/coverage/coverage.source_common_upstream_health_checker_impl.cc.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #6942. This makes it a bit more readable. We
spent some time debugging this too, so it would be nice to ensure
it's readable next time we bump into something around this code
surface :-)
Signed-off-by: Raul Gutierrez Segales rgs@pinterest.com